Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude moment dependency in plugin-check report config #226

Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix: exclude moment dependency in plugin-check report config #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/plugin-check/src/vite-config-for-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,17 @@ export function createViteConfigForReport(
'chart.js'
],

// XXX: The threads.js implementation references `tiny-worker` as an optional
// dependency, but it doesn't get used at runtime, so we can just exclude it
// so that Vite doesn't complain in dev mode
exclude: ['tiny-worker']
exclude: [
// XXX: The threads.js implementation references `tiny-worker` as an optional
// dependency, but it doesn't get used at runtime, so we can just exclude it
// so that Vite doesn't complain in dev mode
'tiny-worker',

// XXX: Similarly, chart.js treats `moment` as an optional dependency, but we
// don't use it at runtime; we need to exclude it here, otherwise Vite will
// complain about missing dependencies in dev mode
'moment'
]
},

// Configure path aliases
Expand Down