Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take DELAY FIXED value from input when delay time = 0 #148

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix: take DELAY FIXED value from input when delay time = 0 #148

merged 2 commits into from
Oct 25, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Oct 20, 2021 •
edited by chrispcampbell
Loading

Fixes #147

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 20, 2021
@ToddFincannon
Copy link
Collaborator Author

The diff for EquationGen.js also contains the code for PR #146. The only revision for this PR is the single change on line 399.

@chrispcampbell chrispcampbell changed the title take DELAY FIXED value from input when delay time = 0 fix: take DELAY FIXED value from input when delay time = 0 Oct 25, 2021
@chrispcampbell chrispcampbell merged commit 328d050 into develop Oct 25, 2021
@chrispcampbell chrispcampbell deleted the todd/147-delay-fixed branch October 25, 2021 20:54
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

DELAY FIXED fails with zero delay time
2 participants
@ToddFincannon @chrispcampbell