fix: get direct data offset from the separated dimension #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispcampbell
changed the title
chrispcampbell
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
@ToddFincannon Looks good to me. I added one non-blocking comment about error handling but it's more a thought for another day. I'll merge this one shortly.
| let ind = sub(this.var.subscripts[0]) | ||
| indexNum = ind.value | ||
| if (this.var.separationDims.length > 1) { | ||
| console.error(`WARNING: direct data variable ${this.var.varName} separated on more than one dimension`) |
There was a problem hiding this comment.
This is not a blocking comment because I think we have other existing cases like this (treating unexpected cases as a soft warning), but I wonder if we should make this and similar cases a hard error (exit with non-zero code). At some point it might be good to revisit error handling in SDE to be a bit more fail-fast and consistent with error reporting mechanisms, but that's for another day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113.
See #113 for details. New case added to the directdata model.