Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GET DIRECT DATA for CSV files #81

Closed
ToddFincannon opened this issue Jul 12, 2021 · 0 comments · Fixed by #82 or #190
Closed

Implement GET DIRECT DATA for CSV files #81

ToddFincannon opened this issue Jul 12, 2021 · 0 comments · Fixed by #82 or #190
Assignees
@ToddFincannon
Labels
feature
Milestone
0.6.0

Comments

@ToddFincannon
Copy link
Collaborator

Currently, GET DIRECT DATA only works with Excel XLSX files. Extend the implementation to work with CSV files as described in the docs.
@ToddFincannon ToddFincannon self-assigned this Jul 12, 2021
ToddFincannon added a commit that referenced this issue Jul 13, 2021
@ToddFincannon
rename "tag" to "file" and "sheetName" to "tab" for generality (#81)
e47d911
ToddFincannon added a commit that referenced this issue Jul 13, 2021
@ToddFincannon
implement GET DIRECT DATA for CSV files (#81)
77052e5
@chrispcampbell chrispcampbell mentioned this issue Jul 15, 2021
Merged
ToddFincannon added a commit that referenced this issue Jul 24, 2021
@ToddFincannon
fix: read CSV file from a path relative to the model directory (#81)
c05f2f9
@chrispcampbell chrispcampbell added this to the 0.6.0 milestone Jul 24, 2021
ToddFincannon added a commit that referenced this issue Jul 26, 2021
@ToddFincannon
fix: allow CSV read exception to propagate instead of catching it (#81)
e77b8fc
@chrispcampbell chrispcampbell mentioned this issue Jul 26, 2021
Merged
chrispcampbell pushed a commit that referenced this issue Jul 26, 2021
@ToddFincannon
feat: implement GET DIRECT DATA for CSV (#82)
b40e738 
Fixes #81
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ToddFincannon ToddFincannon

Labels
feature
Projects
None yet
Milestone
0.6.0
2 participants
@chrispcampbell @ToddFincannon