Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make browserify an optional dependency #52

Closed
chrispcampbell opened this issue Nov 16, 2020 · 0 comments · Fixed by #53 or #190
Closed

Make browserify an optional dependency #52

chrispcampbell opened this issue Nov 16, 2020 · 0 comments · Fixed by #53 or #190
Assignees
@chrispcampbell
Labels
feature
Milestone
0.6.0

Comments

@chrispcampbell
Copy link
Contributor

Currently browserify is listed as a dependency. The sde generate --genhtml command is the only one relying on browserify. It is a large dependency with many transitive dependencies, but isn't needed in many basic uses of sde. We should remove it as a hard dependency of sdeverywhere, and just update the README to show how to install it when needed.
@chrispcampbell chrispcampbell self-assigned this Nov 16, 2020
@chrispcampbell chrispcampbell added this to the 0.6.0 milestone Nov 16, 2020
@chrispcampbell chrispcampbell mentioned this issue Nov 16, 2020
Merged
@chrispcampbell chrispcampbell changed the title Remove browserify dependency Make browserify an optional dependency Nov 16, 2020
chrispcampbell added a commit that referenced this issue Nov 16, 2020
@chrispcampbell
fix: make browserify an optional dependency (#53)
e9bbbc6 
Fixes #52
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispcampbell chrispcampbell

Labels
feature
Projects
None yet
Milestone
0.6.0
1 participant
@chrispcampbell