feat: add bundleListing, customLookups, and customOutputs settings to control code generation #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomLookups, and customOutputs in model.csv
These are no longer needed now that the runtime package supports output indices buffers of arbitrary length. The preprocessor flag is no longer necessary now that we have the customOutputs directive.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503
This changes the code generator so that it no longer unconditionally emits code for recent features (like the bundled listing and
setLookupfunction) by default. These are now disabled by default since they aren't relevant for most projects, but they can be enabled by flags as needed.See this comment in the issue for more details.
/cc @ToddFincannonEI