-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for controlling whether the minimal model listing is included in the generated model #503
Comments
TL;DR: This has no impact on existing projects. For projects that want to override lookups (or access impl variables), it will now be necessary to set a couple flags to make the code generator include the necessary support code, either in your There were changes needed in a few different packages, as described below. In the
|
In #501 we made it so that a minimal model listing is bundled with the generated model, which makes it possible to create a
LookupDef
without manually initializing aModelListing
. This increases the size of the generated model, but most projects will not need this functionality, so we should either make it opt-in or opt-out. I'm leaning towards making it opt-in.Related to the above, in #472 we added support for overriding lookups at runtime, which resulted in the code generator (for both C and JS) unconditionally including a
setLookup
function that has a case statement for every data or lookup variable in the model. This also increases the size of the generated model, and most projects will not need this functionality, so this should also be made an opt-in thing.The text was updated successfully, but these errors were encountered: