Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external data variables with > 2 dimensions #45

Closed
chrispcampbell opened this issue Sep 17, 2020 · 0 comments · Fixed by #47 or #190
Closed

Add support for external data variables with > 2 dimensions #45

chrispcampbell opened this issue Sep 17, 2020 · 0 comments · Fixed by #47 or #190
Assignees
Labels
Milestone

Comments

@chrispcampbell
Copy link
Contributor

We expanded support for external data variables in #32 but it only handled up to 2 dimensions. The En-ROADS model includes some 3-dimensional external data variables, so we should update the code to handle this case.

Additionally, there was a TODO comment about simplifying the code, and I think we can address that here by generalizing the dimension handling code to work with any number of dimensions (without the need for nested loops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment