Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle XLSX files in GET DIRECT {CONSTANTS,DATA,LOOKUPS} #399

Closed
chrispcampbell opened this issue Nov 15, 2023 · 0 comments · Fixed by #400 or #401
Closed

Handle XLSX files in GET DIRECT {CONSTANTS,DATA,LOOKUPS} #399

chrispcampbell opened this issue Nov 15, 2023 · 0 comments · Fixed by #400 or #401
Assignees
@chrispcampbell
Labels
improvement pkg:compile

Comments

@chrispcampbell
Copy link
Contributor

chrispcampbell commented Nov 15, 2023 •
edited
Loading

Currently SDEverywhere has incomplete support for XLSX files in the GET DIRECT ... functions. See the "matrix" below.

We should unify the handling for these two functions so that any of the options supported by Vensim are also supported by SDEverywhere.

GET DIRECT {DATA,LOOKUPS} currently supports:

  • an Excel file referenced using an indirect tag (?data), which must be set up in the spec.json, OR
  • a CSV file referenced by file name ('data.csv')

GET DIRECT {DATA,LOOKUPS} does not currently support:

  • an Excel file referenced by file name ('data.xlsx')

GET DIRECT CONSTANTS currently supports:

  • a CSV file referenced by file name ('data.csv')

GET DIRECT CONSTANTS does not currently support:

  • an Excel file referenced using an indirect tag (?data), which must be set up in the spec.json, OR
  • an Excel file referenced by file name ('data.xlsx')
@chrispcampbell chrispcampbell self-assigned this Nov 15, 2023
@chrispcampbell chrispcampbell changed the title Handle XLSX files in GET DIRECT {CONSTANTS,DATA} Handle XLSX files in GET DIRECT {CONSTANTS,DATA} Nov 15, 2023
@chrispcampbell chrispcampbell changed the title Handle XLSX files in GET DIRECT {CONSTANTS,DATA} Handle XLSX files in GET DIRECT {CONSTANTS,DATA,LOOKUPS} Nov 15, 2023
@chrispcampbell chrispcampbell mentioned this issue Nov 15, 2023
Merged
chrispcampbell added a commit that referenced this issue Nov 15, 2023
@chrispcampbell
fix: handle XLSX files in GET DIRECT {CONSTANTS,DATA,LOOKUPS} (#400)
16b1ddf 
Fixes #399
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispcampbell chrispcampbell

Labels
improvement pkg:compile
Projects
None yet
Milestone
No milestone
1 participant
@chrispcampbell