fix: allow lowercase cell reference in GET DIRECT function calls #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
This is a simple fix that allows
GET DIRECT ...calls to use a cell reference that has lowercase letters instead of the more typical uppercase ones. Vensim is lenient and allows either form, but the XLSX library we use in SDE is not lenient, so I've added atoUpperCase()call in the appropriate places.I also added some error handling so that users will get a more useful error message in the unlikely case where an invalid cell reference is used (instead of allowing things to pass through).
I updated the existing integration tests and also added some new unit tests to verify this.