Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lowercase cell reference in GET DIRECT ... function calls #395

Closed
chrispcampbell opened this issue Nov 14, 2023 · 0 comments · Fixed by #396 or #401
Closed

Allow lowercase cell reference in GET DIRECT ... function calls #395

chrispcampbell opened this issue Nov 14, 2023 · 0 comments · Fixed by #396 or #401

Comments

@chrispcampbell
Copy link
Contributor

I received a Vensim model that makes use of GET DIRECT DATA and GET DIRECT CONSTANTS, and the cell argument uses lowercase letters, like this:

	GET DIRECT CONSTANTS('?data', 'sheet' , 'c5' )

This works in Vensim, but does not currently work in SDEverywhere because the underlying library that reads xlsx files is not lenient. If we convert the cell reference to uppercase, then it works fine.

As part of this, we should also handle the case where XLSX.utils.decode_cell fails to decode and throw a more useful error message. In the current implementation, processing continues and you won't know about the failure until the C or WASM compiler reports a compilation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant