Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ramda imports #349

Closed
chrispcampbell opened this issue Sep 1, 2023 · 0 comments · Fixed by #350 or #353
Closed

Update ramda imports #349

chrispcampbell opened this issue Sep 1, 2023 · 0 comments · Fixed by #350 or #353

Comments

@chrispcampbell
Copy link
Contributor

I was working on adding some new tests in the compile package (to expand coverage of existing behavior) and found that vitest doesn't work with the existing import style for ramda.

We currently use:

import R from 'ramda'

We are currently on [email protected] and have been for some time, but I found in the 0.25 upgrade guide that when they changed to ESM, they said the import style needs to be changed to:

import * as R from 'ramda'

See 0.25 upgrade guide:
ramda/ramda#2319

Once I made this change, then vitest has no problem importing all the compile package sources that use ramda. And it has no impact on behavior (tests all pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant