Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison graph colors are reversed #279

Closed
chrispcampbell opened this issue Oct 29, 2022 · 0 comments · Fixed by #280 or #281
Closed

Comparison graph colors are reversed #279

chrispcampbell opened this issue Oct 29, 2022 · 0 comments · Fixed by #280 or #281
Assignees
@chrispcampbell
Labels
bug pkg:check-ui-shell

Comments

@chrispcampbell
Copy link
Contributor

chrispcampbell commented Oct 29, 2022 •
edited
Loading

I recently (in PR #246) changed the global styles so that we use crimson for the "baseline" color and deepskyblue for the "current" color. Unfortunately I forgot to update the code in comparison-graph-view.ts where we hardcode those colors, so the graph colors are appearing incorrectly swapped.

INCORRECT:

image

CORRECTED:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispcampbell chrispcampbell

Labels
bug pkg:check-ui-shell
Projects
None yet
Milestone
No milestone
1 participant
@chrispcampbell