Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vite a peer dependency for plugin-vite #268

Closed
chrispcampbell opened this issue Oct 24, 2022 · 0 comments · Fixed by #269 or #266
Closed

Make vite a peer dependency for plugin-vite #268

chrispcampbell opened this issue Oct 24, 2022 · 0 comments · Fixed by #269 or #266
Assignees

Comments

@chrispcampbell
Copy link
Contributor

Currently plugin-vite lists vite as a hard dependency:

  "dependencies": {
    "vite": "^3.1.3"
  },

Since this plugin is meant to be used to run some arbitrary vite build step as part of the overall SDE build process, it would be better to list vite as a peer dependency so that the parent project can control which version is used. (Any 3.x version should work.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant