Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for selecting different model-check baseline bundle in local dev mode #246

Merged
merged 14 commits into from
Sep 27, 2022

Conversation

chrispcampbell
Copy link
Contributor

@chrispcampbell chrispcampbell commented Sep 27, 2022

Fixes #244

This improves the check-ui-shell package and the model-check report template used by plugin-check so that it is now possible for the user to save a baseline bundle and select from a list of available bundles in the report header. See screenshot below.

The plugin-check package now exposes an sde-check cli tool that currently only contains one command:

sde-check baseline --save

This will copy the current sde-prep/check-bundle.js file to the baselines directory and rename it to include a timestamp.

The report created by plugin-check will refresh automatically when bundles are added/removed, and the report will also update when the user chooses a new "baseline" or "current" bundle.

As part of this PR, I also made a few usability improvements in the model-check report that I've been wanting to do for some time:

  • swapped the dataset colors ("baseline" is now red, "current" is now blue)
  • fixed the bundle generated by plugin-check so that it correctly reports the size of the model
  • the state of the "Simplify Scenarios" checkbox is preserved when the page is reloaded
  • the graph for the first failing check is now expanded/displayed automatically

image

@chrispcampbell chrispcampbell merged commit 6425eb8 into main Sep 27, 2022
@chrispcampbell chrispcampbell deleted the chris/244-choose-baseline branch September 27, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for selecting different model-check baseline bundle in local dev mode
1 participant