Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create package reports error for install dependencies step #239

Closed
chrispcampbell opened this issue Sep 24, 2022 · 0 comments · Fixed by #249 or #245
Closed

Create package reports error for install dependencies step #239

chrispcampbell opened this issue Sep 24, 2022 · 0 comments · Fixed by #249 or #245
Assignees

Comments

@chrispcampbell
Copy link
Contributor

The create package always reports an error when installing npm dependencies because I forgot to include a proper check for the exit code:

      installExec.on('exit', code => reject(`Install failed (code=${code})`))

Just need to change that to only reject if the exit code is non-zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant