Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build package a peer dependency for plugins #237

Closed
chrispcampbell opened this issue Sep 24, 2022 · 0 comments · Fixed by #241 or #245
Closed

Make build package a peer dependency for plugins #237

chrispcampbell opened this issue Sep 24, 2022 · 0 comments · Fixed by #241 or #245
Assignees
@chrispcampbell
Labels
improvement pkg:build pkg:plugin-check pkg:plugin-config pkg:plugin-vite pkg:plugin-wasm pkg:plugin-worker

Comments

@chrispcampbell
Copy link
Contributor

Currently the plugin packages list the build package as a regular direct dependency. Due to the way we have release-please set up using "node-workspace" mode, any time we bump the build package version, release-please will bump all the plugins even when there are no relevant API changes. I think it would be better to:

  • list build in peerDependencies for each plugin package
  • change the examples/templates to list build as a dependency (shouldn't technically be needed if cli is a dependency, but I think pnpm will complain otherwise)
@chrispcampbell chrispcampbell self-assigned this Sep 24, 2022
@chrispcampbell chrispcampbell mentioned this issue Sep 25, 2022
Merged
chrispcampbell added a commit that referenced this issue Sep 25, 2022
@chrispcampbell
fix: make build package a peer dependency for plugins (#241)
05ea85f 
Fixes #237
chrispcampbell added a commit that referenced this issue Sep 26, 2022
@chrispcampbell
build: replace workspace:* with just * to workaround lack of pnpm…
79ab63c 
… support in release-please node-workspace plugin (#237)
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispcampbell chrispcampbell

Labels
improvement pkg:build pkg:plugin-check pkg:plugin-config pkg:plugin-vite pkg:plugin-wasm pkg:plugin-worker
Projects
None yet
Milestone
No milestone
1 participant
@chrispcampbell