Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-tests.js not generated before watch/serve mode starts #211

Closed
chrispcampbell opened this issue Jul 8, 2022 · 0 comments · Fixed by #217 or #213
Closed

check-tests.js not generated before watch/serve mode starts #211

chrispcampbell opened this issue Jul 8, 2022 · 0 comments · Fixed by #217 or #213

Comments

@chrispcampbell
Copy link
Contributor

There is a timing issue in the way plugin-check runs in watch/serve mode. If a testConfigPath is not provided, we generate a default config, but currently this step is skipped in postBuild in development mode, since it supposed to be covered by watch. But for an initial sde watch, there is a race condition, so the check-tests.js may not be created before the report dev server starts.

To resolve this, we should probably just run the genTestConfig step in development mode, only for the initial postBuild call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant