Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rollup-plugin-node-polyfills dependency #210

Closed
chrispcampbell opened this issue Jul 8, 2022 · 0 comments · Fixed by #212 or #213
Closed

Remove rollup-plugin-node-polyfills dependency #210

chrispcampbell opened this issue Jul 8, 2022 · 0 comments · Fixed by #212 or #213

Comments

@chrispcampbell
Copy link
Contributor

Currently the plugin-check package has a dependency on rollup-plugin-node-polyfills, which is no longer maintained and depends on deprecated packages. There is a replacement (rollup-plugin-polyfill-node) but for our purposes, it would probably be better to just provide our own custom no-op polyfills since the code is not actually used in the browser at runtime. (The polyfills are only needed as fallout from our approach of generating a single "check bundle" that can work in both Node and browser environments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment