Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct GET DIRECT DATA with mapped dim by directly comparing indices #146

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix: correct GET DIRECT DATA with mapped dim by directly comparing indices #146

merged 2 commits into from
Oct 25, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Oct 19, 2021 •
edited by chrispcampbell
Loading

Fixes #145

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 19, 2021
@ToddFincannon ToddFincannon mentioned this pull request Oct 20, 2021
Merged
@chrispcampbell chrispcampbell changed the title fix GET DIRECT DATA with mapped dim by directly comparing indices fix: correct GET DIRECT DATA with mapped dim by directly comparing indices Oct 25, 2021
chrispcampbell
chrispcampbell approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass, so it must be OK 😄

@chrispcampbell chrispcampbell merged commit fa2097b into develop Oct 25, 2021
@chrispcampbell chrispcampbell deleted the todd/145-direct-data branch October 25, 2021 20:49
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

GET DIRECT DATA fails when its dimension is mapped
2 participants
@ToddFincannon @chrispcampbell