Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove fcmp library and rewrite expressions without using its macros #131

Merged
merged 1 commit into from
Oct 8, 2021
Merged

fix: remove fcmp library and rewrite expressions without using its macros #131

merged 1 commit into from
Oct 8, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Oct 8, 2021 •
edited by chrispcampbell
Loading

Fixes #107

@ToddFincannon ToddFincannon added the dependencies Pull requests that update a dependency file label Oct 8, 2021
@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 8, 2021
@chrispcampbell chrispcampbell changed the title remove the fcmp library and rewrite expressions without using its macros fix: remove fcmp library and rewrite expressions without using its macros Oct 8, 2021
chrispcampbell
chrispcampbell approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Will merge shortly.

@chrispcampbell chrispcampbell merged commit df76872 into develop Oct 8, 2021
@chrispcampbell chrispcampbell deleted the todd/107-fcmp branch October 8, 2021 22:59
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Remove unused fcmp GPL2 code
2 participants
@ToddFincannon @chrispcampbell