Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused fcmp GPL2 code #107

Closed
ToddFincannon opened this issue Aug 31, 2021 · 1 comment · Fixed by #131 or #190
Closed

Remove unused fcmp GPL2 code #107

ToddFincannon opened this issue Aug 31, 2021 · 1 comment · Fixed by #131 or #190
Assignees
Milestone

Comments

@ToddFincannon
Copy link
Collaborator

At one time, we used the fcmp library to get high-precision floating-point comparisons. We ended up not using it. This is a GPL v2 library incompatible with the MIT license, so we should remove it. This would require changing the sde.h header to remove the unused fcmp option.

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Aug 31, 2021
@ToddFincannon ToddFincannon self-assigned this Aug 31, 2021
@ToddFincannon
Copy link
Collaborator Author

I went ahead and replaced the macros that served as a shim for fcmp macros everywhere they occurred in the C code. They were all simple, and they only occurred in a few places. So fgt(a, b) is now a > b etc., which seems like an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment