Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tick mark for the initial slider value #11

Closed
travisfranck opened this issue Nov 9, 2018 · 4 comments · Fixed by #267
Closed

Add tick mark for the initial slider value #11

travisfranck opened this issue Nov 9, 2018 · 4 comments · Fixed by #267

Comments

@travisfranck
Copy link
Collaborator

It would be nice to have a tick mark for the the initial slider value. This would allow users to see a what has changed from defaults, and also allow them to move individual slides to their default values more easily.

@chrispcampbell
Copy link
Contributor

This issue was written back in the pre-0.7 days when there was a --genhtml feature that allowed for generating an app with a specific layout.

Similar to my last comment in #14, the app code in template-default is intentionally minimal so that users can more easily understand the code while still allowing them to configure the generated app in whatever way makes sense for their model. I'm not sure that we should add lots of UI features or specific improvements to the default template, but instead keep the door open to different app templates provided by developers.

So, I'm going to close this as "will not fix", but I'd be happy to accept new issues / PRs that provide new or improved project templates that offer different UI features for generated apps.

@chrispcampbell chrispcampbell closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2022
@travisfranck
Copy link
Collaborator Author

I don't know if I would think of this too much as a "feature" that is arbitrary. The main thing is that, for almost all (or all?) sliders it is useful to do know the default value. Once a user moves it, they lose this information. If SDE only does one kind of slider style, I suggest a 'tick' be the default.

@chrispcampbell
Copy link
Contributor

@travisfranck: I think I was kind of using this issue to make a larger point that there's a slippery slope where if we add lots of fine tuning to the app template code, it potentially increases the complexity and "understandability" of the code. I've been erring on the side of keeping the template as minimal as possible because I don't want SDE to get into the business of a once-size-fits-all (or even super configurable) app layout for model/simulator apps. (It might be nice to have a standard UI component library for SDE, or maybe as a @climateinteractive thing, but that's a separate ball of wax.)

Anyway, my feelings about maintaining UI tweaks can be kept for a separate discussion thread. I guess having a tick mark is a small thing to add, so I'll just reopen and fix and put philosophical stuff aside. I'll note that in the current app template we already have track highlighting (like in En-ROADS), so when you move the slider, you don't lose track of the default value like you said above. But having both track highlighting and a tick mark (like we have in En-ROADS) seems fine, and like I said, easy to add, so I'll just do it. Screenshot below.

image

@travisfranck
Copy link
Collaborator Author

Thanks. I think the issue was written before track highlighting was implemented, but I think the tick mark is nice. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants