Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC-CUBE#989 不具合回避案 #1

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

seasoftjapan
Copy link

EC-CUBE#989 (review) の不具合回避案です。

ページクラスで処理せず、SC_Helper_Mail::sfSendRegistMail() を呼び出すように変更した。
@seasoftjapan
Copy link
Author

GitHub 不慣れで、こんな PR の使い方で良いのか分かりませんが。。。

@clicktx
Copy link
Owner

clicktx commented Sep 6, 2024

LGTM(使ってみたかっただけ汗)
登録メールの送信部分のコードの重複が消えてスッキリします。

自分も不慣れでPRのPR初めてなので今後の処理があっているか不安です。。。

@clicktx clicktx merged commit f85e954 into clicktx:fix/sc_helper_mail Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants