Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for hidden commands and options #86

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

GhostOps77
Copy link
Contributor

@GhostOps77 GhostOps77 commented Feb 3, 2023

Changes done in this branch:

  • Merged code with PR Fix: filter hidden commands&options #65
  • Added ignore C901 for flake8 (or else, the PR will fail, for the reason that ClickCompleter.get_completions is too complex)
  • Added test cases for hidden command & options in tests/test_basic.py

	Added ignore C901 for flake8:   setup.cfg
	Added test cases for hidden command & options:   tests/test_basic.py
@GhostOps77
Copy link
Contributor Author

@auvipy waiting for ur review man

@auvipy auvipy requested review from auvipy and untitaker February 3, 2023 13:53
@@ -36,7 +36,7 @@ class ClickExit(RuntimeError):
text_type = str # noqa


__version__ = "0.2.0"
__version__ = "0.2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i swear, there must be a dev branch for these type of changes
so that i can give 0.2.1dev as the version

@GhostOps77 GhostOps77 requested review from auvipy and removed request for untitaker February 3, 2023 14:45
@auvipy auvipy merged commit 7f5cd1a into click-contrib:master Feb 3, 2023
@GhostOps77 GhostOps77 deleted the filter-hidden-commands branch February 3, 2023 15:10
@GhostOps77
Copy link
Contributor Author

Solves issue: #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants