Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github actions and added example running on alpine #45

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

tubbynl
Copy link
Contributor

@tubbynl tubbynl commented Sep 10, 2024

updated github actions to v4

  • using macos-13 for the Java CI on Mac (curious if m1 / arm64 would impact)
  • using maven:3.9-eclipse-temurin-11-alpine base image for Java CI on Linux Alpine

not copying pom from musl/test-project as proof of concept

that seems to indicate that setting <os>linux-musl</os> is required for running on alpine images, should that be auto-detected or is it by-design?

@tubbynl tubbynl changed the title update github actions and added example for #44 update github actions and added example running on alpine Sep 10, 2024
@tubbynl tubbynl mentioned this pull request Sep 10, 2024
@tubbynl tubbynl marked this pull request as draft September 10, 2024 08:11
@tubbynl tubbynl force-pushed the feature/test-github-actions branch from 0ed4a7e to a57d284 Compare September 11, 2024 07:21
@tubbynl tubbynl marked this pull request as ready for review September 11, 2024 07:22
@tubbynl
Copy link
Contributor Author

tubbynl commented Sep 11, 2024

i think the rest of this pull request makes sense @cleydyr

@cleydyr
Copy link
Owner

cleydyr commented Sep 11, 2024

Hey, @tubbynl . Thank you for this PR. I'm thinking of adding musl auto detection for Linux OSes, but for now, the warning you added to the README makes sense.

@cleydyr cleydyr merged commit d442613 into cleydyr:master Sep 11, 2024
1 check passed
@tubbynl tubbynl deleted the feature/test-github-actions branch September 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants