fix(backend): Support the Vercel edge-light runtime key #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edge-light runtime key was recently added as a condition name for the edge runtime in this PR: vercel/next.js#45188 However, this PR also introduced a change (which might not be intentional): the `node` runtime key is now a valid condition key for the edge runtime, so it matches before our `default` import. This PR adds the `edge-light` key before `node` so that we guarantee that the correct imports will always be used.
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
nikosdouvlis
deleted the
nikos/js-203-fix-middleware-again-for-nextjs
branch
21 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastifygatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.The edge-light runtime key was recently added as a condition name for the edge runtime in this PR: vercel/next.js#45188
However, this PR also introduced a change (which might not be intentional): the
noderuntime key is now a valid condition key for the edge runtime, so it matches before ourdefaultimport.This PR adds the
edge-lightkey beforenodeso that we guarantee that the correct imports will always be used.