Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Bundle Accountless only in dev #4649

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

panteliselef
Copy link
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:04pm

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: b06d04b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski tmilewski self-requested a review November 25, 2024 16:25
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef Following-up here, per our DM:

This all looks cool, but I'd suggest that we use specific flags vs __DEV__ directly.

It'll make it easier to follow over time, and if/when we need to remove it.

Seeing as we only need it in the dev environment, the flag could follow a format such as __BUILD_FLAG_ACCOUNTLESS__, and rely on the same conditions as __DEV__.

/cc @BRKalow

@panteliselef panteliselef merged commit 2d3866c into main Nov 25, 2024
27 checks passed
@panteliselef panteliselef deleted the elef/bundle-accountless-only-dev branch November 25, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants