-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js): Bundle Accountless only in dev #4649
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b06d04b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panteliselef Following-up here, per our DM:
This all looks cool, but I'd suggest that we use specific flags vs __DEV__
directly.
It'll make it easier to follow over time, and if/when we need to remove it.
Seeing as we only need it in the dev environment, the flag could follow a format such as __BUILD_FLAG_ACCOUNTLESS__
, and rely on the same conditions as __DEV__
.
/cc @BRKalow
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change