fix(elements): Add check for relatedTarget to avoid validation running immediately after unsuccessful form submission
#3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 66d4e70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
changed the title
onFocus callback from common input
alexcarpenter
changed the title
onFocus callback from common inputrelatedTarget to avoid validation running immediately after unsuccessful form submission
tmilewski
approved these changes
Jul 18, 2024
alexcarpenter
deleted the
alexcarpenter/sdki-154-validatepassword-usage-causing-inconsistent-errors-with-pwnd
branch
alexcarpenter
added a commit
that referenced
this pull request
Jul 19, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where an invalid password field was immediately being refocused after submission causing the validation to run and show the success state.
BEFORE:
Screen.Recording.2024-07-18.at.5.10.30.PM.mov
AFTER:
Screen.Recording.2024-07-18.at.5.09.29.PM.mov
https://linear.app/clerk/issue/SDKI-154/validatepassword-usage-causing-inconsistent-errors-with-pwnd-message
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change