-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-expo): Deprecate useOAuth
and introduce docs for useSSO
#1908
Conversation
Hey, here’s your docs preview: https://clerk.com/docs/pr/1908 |
47515ed
to
a6bdd0a
Compare
47aba5d
to
ba0aeb1
Compare
docs/references/expo/use-sso.mdx
Outdated
|
||
<Tabs items={["With OAuth", "With SAML"]}> | ||
<Tab> | ||
The following example demonstrates how to create a custom SSO sign-in flow for [Google accounts](/docs/authentication/social-connections/google). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a custom sign-in flow, do we still want to link to this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which page? Do you mean /docs/authentication/social-connections/google?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Would it make sense?
Hey @LauraBeatris, here's my review. Update: d13a572
Notes
|
We should also update for: https://clerk.com/docs/custom-flows/oauth-connections |
c4d0914
to
f9621d8
Compare
Hi! Just did a review, and a question:
Summary of my review:
|
29c7a0b
to
aba6dc2
Compare
Will test the custom flow code when the JavaScript PR is ready to merge/is merged. Outstanding question: |
Co-authored-by: victoria <[email protected]> Co-authored-by: Alexis Aguilar <[email protected]>
c5b9f1d
to
81107e2
Compare
fe5f63f
to
1fff4b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wooooooooo !! 🥳
oh wait, there's a TODO there for ya @LauraBeatris |
@alexisintech We need to merge https://github.com/clerk/clerk/pull/941 right after this one as well! |
Related: #1907
Important
🔎 Previews:
Explanation:
A new React hook got added to
@clerk/expo
to handle all SSO strategies, such as SAML and social/custom OAuthuseOAuth
got deprecated in favor ofuseSSO
This PR:
Resolves ORGS-460
useOAuth
guideuseSSO
Checklist