Iterable Sensors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SENSOR_TYPE = "camera" | ||
| CAMERA_MODEL = "base" | ||
| NAME = SENSOR_TYPE + "_0" | ||
| TOPIC = NAME + "/image" |
There was a problem hiding this comment.
I believe this should be /image_raw
| CONNECTION_TYPE = USB3_CONNECTION | ||
| CONNECTION_TYPES = [USB3_CONNECTION, GIGE_CONNECTION] | ||
|
|
||
| MONO_8 = "Mono8" |
There was a problem hiding this comment.
Should there be file with all these consts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensors are organized by
TYPEand thenMODEL.In the YAML, all sensors go under the
sensorskey, and then under the subkey corresponding to theirTYPE(i.e.lidar2d,camera, etc.).Models of each
TYPEare added to a list sensors of the sameTYPE. That means sensors are numbered based on theirTYPEnot theirMODEL.There are class methods to access specific sensors by
MODEL.