Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of Golang for Travis #31

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

mdhorn
Copy link
Contributor

@mdhorn mdhorn commented Aug 14, 2018

Fixes Issue:
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead of 1.10.
See: travis-ci/travis-ci#9247

Changes proposed in this pull request:

  • Adding quotes so it is treated as a string.

@mdhorn mdhorn requested a review from dorileo August 14, 2018 20:54
@mdhorn mdhorn removed the request for review from dorileo August 14, 2018 22:59
@mdhorn mdhorn force-pushed the travis-fix branch 11 times, most recently from e8c9f38 to dcc69e1 Compare August 15, 2018 17:26
@dorileo
Copy link
Contributor

dorileo commented Aug 15, 2018

+1

Copy link
Contributor

@dorileo dorileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdhorn
Copy link
Contributor Author

mdhorn commented Aug 15, 2018

@dorileo going through several cycles trying to configure a Clear Linux Docker image to run the builds and test instead of the default ubuntu 14.04.

@dorileo
Copy link
Contributor

dorileo commented Aug 15, 2018

go ahead

@mdhorn mdhorn force-pushed the travis-fix branch 4 times, most recently from a983766 to bd8362a Compare August 15, 2018 21:32
Fix version of Golang for Travis
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.
See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.
- Telemetry not starting due to systemd issues
- Disabled Telemetry testing under this is resolved

Signed-off-by: Mark D Horn <[email protected]>
@mdhorn mdhorn merged commit 72c68da into clearlinux:master Aug 15, 2018
@mdhorn mdhorn deleted the travis-fix branch August 15, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants