Merge pull request #5 from clearfeed/APP-4559

APP-4559 fix rendering group mention
clearfeed · Sep 16, 2024 · 3ece4ca · 3ece4ca
2 parents 89918ea + fad75fe
commit 3ece4ca
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/dist/bundle.js b/dist/bundle.js
diff --git a/dist/index.js b/dist/index.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@clearfeed-ai/slack-to-html",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Render Slack markdown as HTML",
   "main": "dist/bundle.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -119,7 +119,7 @@ const replaceUserGroupName = (usergroups) => (match) => {
     match.subteamName ||
     (match.subteamID && usergroups && usergroups[match.subteamID])
   if (userGroupName) {
-    return `${userGroupName}`
+    return `@${userGroupName}`
   }
   return escapeTags(match.toString())
 }

diff --git a/test/controlSequenceTest.js b/test/controlSequenceTest.js
@@ -91,11 +91,15 @@ describe('control sequences', () => {
 
       describe('for the subteam command', () => {
         it('should render as a group link when the label is present', () => {
-          escapeForSlack('<!subteam^S123|swiftype-eng>').should.equal('swiftype-eng')
+          escapeForSlack("<!subteam^S123|swiftype-eng>").should.equal(
+            "@swiftype-eng"
+          );
         })
 
         it('should render the group name if present', () => {
-          escapeForSlack('<!subteam^S123>', { usergroups: { S123: 'swiftype-eng' } }).should.equal('swiftype-eng')
+          escapeForSlack("<!subteam^S123>", {
+            usergroups: { S123: "swiftype-eng" },
+          }).should.equal("@swiftype-eng");
         })
 
         it('should render the original value if the channel name is not present', () => {