Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Add script to install go version from versions file #966

Open
jcvenegas opened this issue Apr 5, 2018 · 0 comments
Open

Add script to install go version from versions file #966

jcvenegas opened this issue Apr 5, 2018 · 0 comments

Comments

@jcvenegas
Copy link
Contributor

From: @jodh-intel in clearcontainers/runtime#1086

Actually, there are a couple of issues here:

fwics we're building packages with go 1.7 fwics:

https://github.com/clearcontainers/packaging/blob/master/.ci/setup.sh#L26

The dev guide mention 1.8.3:

https://github.com/clearcontainers/runtime/blob/master/docs/developers-clear-containers-install.md#requirements-to-build-individual-components

In summary:

we're building packages with a very old version of go
we're recommending developers build with an old version of go (but newer than the packaging version).
we're testing with a newer (but not the latest) version of go.
We have a plan for how to resolve this for Kata but it's something we should be aware of I think:

kata-containers/runtime#114 (comment)

To reduce this gap we should consider add to our ci an script that installs a go version defined in versions.txt file from runtime.

jcvenegas added a commit to jcvenegas/cc-tests that referenced this issue Apr 5, 2018
This script will install the recommened version
in versions.txt from runtime.

Fixes: clearcontainers#966

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/cc-tests that referenced this issue Apr 5, 2018
This script will install the recommened version
in versions.txt from runtime.

Fixes: clearcontainers#966

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/cc-tests that referenced this issue Apr 5, 2018
This script allow to install the golang version
defined in Clear Containers versions file.

It also takes as argument the version to be installed.

E.g.

- Install go 1.10
./install_go.sh 1.10

- Install go using versions file from project.
./install_go.sh -p

Fixes: clearcontainers#966

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/cc-tests that referenced this issue Apr 5, 2018
This script allow to install the golang version
defined in Clear Containers versions file.

It also takes as argument the version to be installed.

E.g.

- Install go 1.10
./install_go.sh 1.10

- Install go using versions file from project.
./install_go.sh -p

Fixes: clearcontainers#966

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
mcastelino pushed a commit to mcastelino/tests that referenced this issue Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant