This repository has been archived by the owner on May 6, 2020. It is now read-only.
CI: jenkins script 'go get' should not try to build the repo #887
Assignees
Comments
grahamwhaley
pushed a commit
to grahamwhaley/tests
that referenced
this issue
Feb 5, 2018
Without a '-d' on the 'go get', the script ties to build the repos, and for repos that do not work under 'go build', this leaves errors in the CI logs. We don't need a build at this stage as we invoke the repo specific builds later on. Also, some CIs do not clean out their build trees between builds, and thus have repos already present - so add an 'update -u' flag as well. Fixes: clearcontainers#887 Signed-off-by: Graham Whaley <[email protected]>
grahamwhaley
pushed a commit
to grahamwhaley/tests
that referenced
this issue
Feb 5, 2018
Without a '-d' on the 'go get', the script ties to build the repos, and for repos that do not work under 'go build', this leaves errors in the CI logs. We don't need a build at this stage as we invoke the repo specific builds later on. Also, some CIs do not clean out their build trees between builds, and thus have repos already present - so add an 'update -u' flag as well. Fixes: clearcontainers#887 Signed-off-by: Graham Whaley <[email protected]>
grahamwhaley
pushed a commit
to grahamwhaley/tests
that referenced
this issue
Mar 27, 2018
Without a '-d' on the 'go get', the script ties to build the repos, and for repos that do not work under 'go build', this leaves errors in the CI logs. We don't need a build at this stage as we invoke the repo specific builds later on. Also, some CIs do not clean out their build trees between builds, and thus have repos already present - so add an 'update -u' flag as well. Fixes: clearcontainers#887 Signed-off-by: Graham Whaley <[email protected]>
mcastelino
pushed a commit
to mcastelino/tests
that referenced
this issue
Jan 23, 2019
test: Add entropy test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Early in https://github.com/clearcontainers/tests/blob/master/.ci/jenkins_job_build.sh#L52 we fetch the repo to test with a
got get, but as it has no-d, it tries a genericgo buildof the repo. This is not wanted as:go buildthem, and thus list line injects confusing build errors into the CI logs.Change this to not build by adding a
-d. Whilst there, also add a-u, as some CIs do not clear out their build trees between builds, so may already have a repo present, and hence really need an 'update' arg as well.The text was updated successfully, but these errors were encountered: