Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read segments from JWT (DEV-7295) #5

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Conversation

peter-horvath
Copy link
Contributor

No description provided.

@@ -229,6 +247,14 @@ public function givenTokenWithoutGroupId_whenVerifyingToken_returnTrue()
/**
* @test
*/
public function givenTokenWithoutSegments_whenVerifyingToken_returnTrue()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a token without segments valid?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I see it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to revoke access from users with tokens issued without segments by a previous version of the code. I think right now they would be locked out from preview until they delete their cookies or until their token expires. Most users won't have segments for now anyway.

@luos
Copy link

luos commented Mar 8, 2016

Looks OK 💯

peter-horvath added a commit that referenced this pull request Mar 8, 2016
read segments from JWT (DEV-7295)
@peter-horvath peter-horvath merged commit ab1056d into master Mar 8, 2016
@peter-horvath peter-horvath deleted the DEV-7295-segments branch March 8, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants