Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF datasets version fix #249

Merged
merged 3 commits into from
Jan 31, 2024
Merged

HF datasets version fix #249

merged 3 commits into from
Jan 31, 2024

Conversation

sanjanag
Copy link
Member

@sanjanag sanjanag commented Jan 29, 2024

CI fixes:

  • Install different versions of datasets for different python versions. Can't use same version as datasets dropped support for python3.7 in version 2.14.0 and it breaks tests using datasets library.
  • Use black formatting for jupyter notebooks as well
  • Update versions of black and flake8 precommit hooks
  • Ignore flake8 error E704 as it is conflicting with black formatting
  • Add target versions for black in CI pipeline and only use check option and not modify the files.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af3fc3f) 95.84% compared to head (dd1e190) 96.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   95.84%   96.04%   +0.19%     
==========================================
  Files          16       16              
  Lines         987      985       -2     
  Branches      194      194              
==========================================
  Hits          946      946              
+ Misses         21       19       -2     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sanjanag sanjanag marked this pull request as ready for review January 30, 2024 00:22
@sanjanag sanjanag requested a review from elisno January 30, 2024 00:23
Copy link
Member

@elisno elisno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sanjanag sanjanag merged commit 1a6f537 into cleanlab:main Jan 31, 2024
24 checks passed
@sanjanag sanjanag deleted the version-fix branch January 31, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants