Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve formatting of the quickstart tutorial #240

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

jwmueller
Copy link
Member

to review this please build docs and see that the improvements look good to you too

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

"\n",
"unzip -q image_files.zip"
]
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand why there was these commands in the markdown cell and then again in hidden code cell. These commands did not look good in the markdown cell on our website:

Screen Shot 2023-11-16 at 7 58 52 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-17 at 9 32 38 AM
I put it in a hidden cell to hide this output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no tag in nbsphinx that hides just the output, it's either whole cell or nothing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh then can you make it look like code in the markdown cell? on the current website, this just doesn't look like code, which is suboptimal formatting. I agree hiding the output is good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very top of the notebook in the hidden cell that'll be visible in colab that installs cleanvision from master branch, can you also put a comment:

pip install cleanvision to use the stable release of the package instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@@ -804,7 +788,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"**Beyond the collection of image files demonstrated here, you can alternatively run CleanVision on: [Hugging Face datasets](https://github.com/cleanlab/cleanvision/blob/main/docs/source/tutorials/huggingface_dataset.ipynb) and [torchvision datasets](https://github.com/cleanlab/cleanvision/blob/main/docs/source/tutorials/torchvision_dataset.ipynb).**"
"Beyond the collection of image files demonstrated here, you can alternatively run CleanVision on: [Hugging Face datasets](https://github.com/cleanlab/cleanvision/blob/main/docs/source/tutorials/huggingface_dataset.ipynb) and [torchvision datasets](https://github.com/cleanlab/cleanvision/blob/main/docs/source/tutorials/torchvision_dataset.ipynb)."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting here was broken on our website:

Screen Shot 2023-11-16 at 7 59 15 PM

Maybe you have better ideas on how to make this even better looking

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bef81a) 96.04% compared to head (ff68f9b) 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   96.04%   95.84%   -0.21%     
==========================================
  Files          16       16              
  Lines         986      986              
  Branches      194      194              
==========================================
- Hits          947      945       -2     
- Misses         20       21       +1     
- Partials       19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwmueller jwmueller requested a review from sanjanag November 17, 2023 04:02
@sanjanag sanjanag merged commit 9de8f33 into main Nov 20, 2023
22 of 23 checks passed
@sanjanag sanjanag deleted the jwmueller-tutorialformatting branch November 20, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants