Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed type ignore according to type check #234

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

sanjanag
Copy link
Member

@sanjanag sanjanag commented Nov 8, 2023

No description provided.

@sanjanag sanjanag self-assigned this Nov 8, 2023
@sanjanag sanjanag requested a review from elisno November 8, 2023 18:18
Copy link
Member

@elisno elisno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this change passes the black-formatter check in CI.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9531fbc) 95.84% compared to head (962659a) 95.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files          16       16           
  Lines         986      986           
  Branches      194      194           
=======================================
  Hits          945      945           
  Misses         21       21           
  Partials       20       20           
Files Coverage Δ
src/cleanvision/utils/viz_manager.py 98.52% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjanag sanjanag merged commit 969b6a9 into cleanlab:main Nov 8, 2023
22 checks passed
@sanjanag sanjanag deleted the type-check branch November 8, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants