Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for truncate_titles() #232

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Added tests for truncate_titles() #232

merged 2 commits into from
Oct 23, 2023

Conversation

aenlemmea
Copy link
Contributor

Closes #223

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cd8f98b) 95.63% compared to head (028b982) 95.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   95.63%   95.74%   +0.10%     
==========================================
  Files          16       16              
  Lines         986      986              
  Branches      194      194              
==========================================
+ Hits          943      944       +1     
  Misses         22       22              
+ Partials       21       20       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjanag
Copy link
Member

@aenlemmea the test looks good, could you run the black formatter as well as described here https://github.com/cleanlab/cleanvision/blob/main/DEVELOPMENT.md#how-to-style-new-code-contributions

@sanjanag sanjanag self-requested a review October 18, 2023 19:01
@aenlemmea
Copy link
Contributor Author

I made sure to run the command before submitting the PR and oddly enough running it again changed nothing. So I tried installing BlackConnect (on Pycharm) and it did change the formatting now.

@sanjanag sanjanag merged commit 9531fbc into cleanlab:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test for truncate title in case the title is too long in visualization
3 participants