Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data set validation when a logger is supplied #188

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix data set validation when a logger is supplied #188

merged 1 commit into from
Jan 15, 2025

Conversation

johenglisch
Copy link
Contributor

Closes #187

@johenglisch johenglisch requested a review from xrotwang January 15, 2025 08:43
@johenglisch johenglisch mentioned this pull request Jan 15, 2025
Merged
xrotwang
xrotwang approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@xrotwang xrotwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is moving the success = False line above the log_or_raise call strictly necessary?

@johenglisch
Copy link
Contributor Author

No, but I thought if it is in the same place for every instance it makes it easier to spot if one is missing.

@xrotwang
Copy link
Contributor

No, but I thought if it is in the same place for every instance it makes it easier to spot if one is missing.

Ok. Was just checking my intuition :)

@xrotwang
Copy link
Contributor

Should I make a release of pycldf right away?

@johenglisch
Copy link
Contributor Author

I think that would be good, since this fix should be pulled in during CI runs.

@xrotwang xrotwang merged commit 8ef4b92 into master Jan 15, 2025
4 checks passed
@xrotwang xrotwang deleted the logger-breaks-validation branch January 15, 2025 09:04
@xrotwang
Copy link
Contributor

Released with 1.40.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrotwang xrotwang xrotwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test from pytest-cldf pass even when data set is invalid
2 participants
@johenglisch @xrotwang