Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Align Right #83

Closed
lincolnlemos opened this issue May 28, 2015 · 5 comments
Closed

Text Align Right #83

lincolnlemos opened this issue May 28, 2015 · 5 comments
Labels

Comments

@lincolnlemos
Copy link

How can i align the text?
I want right align...

@claviska
Copy link
Owner

This isn't built into the library, but it appears possible.

@mikedidomizio
Copy link
Contributor

I added the code in. The one thing that might be confusing is the default alignment.

Example:

position: top left
default alignment: left

position: top right:
default alignment: right

Maybe there should be a default alignment for text? If left was the default example, and you chose top right for position. You would have to give it a right alignment otherwise it would create the text right off the image

@claviska
Copy link
Owner

I support a default option for alignment, which would depend on the position. If the user specifies alignment, it would obviously override it.

Only problem is this would be considered a breaking change, so I'd prefer to keep the default as-is and add it to the 3.0 roadmap :)

claviska added a commit that referenced this issue Oct 12, 2015
#83 Added the ability to right align text
@claviska
Copy link
Owner

Scratch that. Totally possible since alignment is a new parameter and defaults to null. If you'd like to add this, let me know and I'll hold off on drafting the next release.

@claviska
Copy link
Owner

Added in #100. Please submit a new PR if you want to update the default alignment based on position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants