-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tax2gas #500
feat: tax2gas #500
Conversation
…into minh/tax2gas
@StrathCole @fragwuerdig thanks for all of your comments. After looking at the overall picture and considering all technical aspects, and discussing internally w/wo our consultants, we have come to the conclusion that this is the best version of tax2gas we have. We will put up a proposal for the community to vote on GenuineLabs' tax2gas implementation. |
That's your decision to do of course. |
I am not going to approve this in the current state of implementation.
Sorry to hear, that you have come to this decision :( |
I am sorry, but I cannot approve the PR from my side as I disagree with the implementation in its current state and the effects it would have.
|
As proposal 12120 has passed, this PR will be merged and be pushed on testnet |
This reverts commit d28ff8c.
Summary of changes
Close #481
Test scenario is listed in: https://github.com/classic-terra/core/blob/minh/tax2gas/x/tax2gas/README.md