Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 binance addresses #149

Merged
merged 1 commit into from
Feb 27, 2023
Merged

add 3 binance addresses #149

merged 1 commit into from
Feb 27, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@inon-man
Copy link
Collaborator

It is too late to be updated. The release is out.

@nghuyenthevinh2000
Copy link
Contributor Author

It is too late to be updated. The release is out.

Binance seems to need it now

@inon-man
Copy link
Collaborator

inon-man commented Feb 25, 2023

It is just what it is. Just tell them to make a proposal.

Copy link
Collaborator

@inon-man inon-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release is out.

@inon-man inon-man merged commit 70d118b into main Feb 27, 2023
@edk208
Copy link
Contributor

edk208 commented Feb 27, 2023

adding a note about this PR

Several days ago, during an audit by Binance of v1.1.0, we were informed that there were 3 wallet addresses that were mistakenly not provided to us. These three addresses are,

terra1ncjg4a59x2pgvqy9qjyqprlj8lrwshm0wleht5
terra19l7hzwazq5j0dykfldcwrk2927xwcjd0kt0vt9
terra1frh79vmtur5fmrghz6gfjvfhpa3u2c0uemv4af

As the v1.1.0 release was already in a frozen pre-release stage, we engaged in dialogue on how to best address the missing wallet addresses, I.e. including them in the next release, or utilizing the addition tax exemption governance proposal after the installation of v1.1.0.

Ultimately, we were informed that these three addresses were the most critical ones that needed to be added, otherwise, the tax will be applied to users funds. Given this information, we have included these three wallets into the latest release.

@StrathCole
Copy link
Collaborator

Just as a side-node: The ht5 wallet is the deposit wallet that only moves coins from user deposits to other wallets (mostly sqe main wallet). These are currently taxed anyway (standard double-tax many CEX users experience).
The vt9 and 4af wallets are quite "new" (created ~end of Nov and end of Dec '22).
The 4af wallet seems to be some kind of new deposit wallet regarding the incoming and outgoing tx, so same applies as for ht5.
The vt9 wallet is not yet really used at all.

@faddat
Copy link
Contributor

faddat commented Mar 1, 2023

this what kabomied it?

@faddat faddat mentioned this pull request Mar 1, 2023
@fragwuerdig fragwuerdig deleted the additional-binance-addr branch May 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants