Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tax exemption update #137

Merged
merged 6 commits into from
Feb 20, 2023
Merged

feat: tax exemption update #137

merged 6 commits into from
Feb 20, 2023

Conversation

inon-man
Copy link
Collaborator

@inon-man inon-man commented Feb 20, 2023

Summary of changes

The implementation has been updated to not charge the tax at all for the addresses in the tax exemption list.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@inon-man inon-man mentioned this pull request Feb 20, 2023
8 tasks
@inon-man inon-man requested a review from edk208 February 20, 2023 08:21
@nghuyenthevinh2000
Copy link
Contributor

I have added an integration test to test the tax exemption on whole ante handler stack. It will check for amount change of:

  1. fee collector
  2. burn module
  3. community pool
  4. token supply

that should be all four important one

@nghuyenthevinh2000
Copy link
Contributor

I will just add another script to make sure

@nghuyenthevinh2000 nghuyenthevinh2000 marked this pull request as ready for review February 20, 2023 11:20
Copy link
Contributor

@edk208 edk208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edk208 edk208 merged commit 649f7c4 into main Feb 20, 2023
@fragwuerdig fragwuerdig deleted the tax-exemption branch May 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants