-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: burn tax split bug #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FML your fast! Beat me by like 3 mins. LGTM buddy, I think this is the cleanest solution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Summary of changes
This PR is a bug fix for the Burn Tax Split feature.
The current Burn Tax Split feature does not transfer the community pool amount from the fee collector to the treasury, so the total supply and remaining amount of the fee collector are not accurately calculated.
For example:
total supply = 100
fee collector = 100
burn tax rate = 0.4
split amount = fee collector * burn tax rate = 40
community pool += split amount // fee collector sends 40 to community pool
burn += fee collector - split amount // fee collector sends 60 to burn account
fee collector = 0
total supply = 40
This PR also included removal of TaxPowerSplitHeight as they are no longer needed in v2.x
Report of required housekeeping
(FOR ADMIN) Before merging