Adding custom Eq
instance for Axi4StreamM2S
#66
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derived
Eq
instance always checks the contents of each_tdata
entry , even if the corresponding_tkeep
entry isFalse
.According to the spec, bytes with a low keep signal, do not carry any information.
The current derived implementation leads to undesired failing comparisions:
I imagine this is also the case for some other protocols.