Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugin to a separate package #104

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Move plugin to a separate package #104

merged 4 commits into from
Aug 19, 2024

Conversation

t-wallet
Copy link
Collaborator

Fixes #103

@t-wallet t-wallet linked an issue Aug 15, 2024 that may be closed by this pull request
Move Protocols.Plugin to a separate package #103
Closed
@martijnbastiaan
Copy link
Member

Could you move clash-protocols to a similarly named folder? Like clash-compiler does for its packages. Other than that LGTM.

@t-wallet
Copy link
Collaborator Author

Could you move clash-protocols to a similarly named folder? Like clash-compiler does for its packages. Other than that LGTM.

Done!

martijnbastiaan
martijnbastiaan approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@t-wallet t-wallet merged commit e2f4da3 into main Aug 19, 2024
8 checks passed
@t-wallet t-wallet deleted the 103-move-plugin-to-a-separate-package branch August 19, 2024 12:18
@bgamari
Copy link
Collaborator

bgamari commented Aug 20, 2024 •
edited
Loading

It doesn't seem right that this change is user-visible; requiring the user to add two entries to build-depends just to use this package seems needlessly burdensome.

Why not reexport the plugin from clash-protocols (e.g. using Cabal's reexported-modules feature)?

@martijnbastiaan
Copy link
Member

Agreed, @t-wallet could you re-export?

@bgamari
Copy link
Collaborator

bgamari commented Aug 20, 2024

Done in #106

@DigitalBrains1 DigitalBrains1 mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Protocols.Plugin to a separate package
3 participants
@t-wallet @martijnbastiaan @bgamari