Ila output test fragile

[DigitalBrains1]

As we are separating clash-cores from clash-compiler, I tried to support not just Clash master but also Clash 1.8. But there are several cores in clash-cores that fail their test suite on Clash 1.8 on several GHC versions.

This issue is about the shouldwork/Xilinx/Ila.hs file. It tries to find a specific output file, but that file is called differently in Clash 1.8, even varying with the GHC version.

This line:

clash-cores/test-suite/shouldwork/Xilinx/Ila.hs

Line 103 in 187a87c

[path] <- glob (hdlDir </> "Ila_testWithDefaultsOne_ila.vhdl")

does not find the relevant file as it is called
Ila_testWithDefaultsOne_oneCounter2.vhdl: Clash 1.8.1 with GHC 8.10.7, 9.0.2, 9.2.8
Ila_testWithDefaultsOne_oneCounter1.vhdl: Clash 1.8.1 with GHC 9.4.8, 9.6.6, 9.8.2

The core works fine on Clash master with all supported GHC versions. We could either fix the test or fix the name Clash generates. I'm not saying either solution is viable, just that there potentially are two avenues to pursue.

Pinging @martijnbastiaan as he wrote the code.

An easy to work with repository can be found at clash-cores repro-1.8-issues. You can just do cabal run clash-cores-test-suite -- -j12 -p '/Ila [output test].VHDL/' (although investigating the bug obviously needs more).

[DigitalBrains1]

Also, apart from the file name the test does succeed. If I replace the file name by what it should be, the test succesfully finds the strings it is looking for.