Bump Tasty to released version (1.5) #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package index is already fetched in the "Setup CI" step. Restoring the index from caches means overwriting the up-to-date package index with a potentially older one.
martijnbastiaan
force-pushed
the
bump-tasty
branch
from
ada1810 to
78ddeba
Compare
Cabal's freeze file doesn't include version hashes, just version numbers. This means that updates to dependencies specified in `cabal.project`'s `source-repository-package` field don't get taken into account properly. This issue doesn't affect Stack, as it only relies on version hashes in the first place.
martijnbastiaan
force-pushed
the
bump-tasty
branch
from
78ddeba to
fd4c41a
Compare
leonschoorl
force-pushed
the
bump-tasty
branch
from
6abe185 to
70b3306
Compare
leonschoorl
force-pushed
the
bump-tasty
branch
5 times, most recently
from
07c4426 to
c7c106b
Compare
|
It was good you submitted this as an external PR, there was a problem in the tests we run on external PRs only |
leonschoorl
force-pushed
the
bump-tasty
branch
from
c7c106b to
c0476f1
Compare
I mostly wanted to test my Stack changes, pity the Cabal jobs broke.. |
leonschoorl
force-pushed
the
bump-tasty
branch
2 times, most recently
from
2e92600 to
7865ebd
Compare
|
@DigitalBrains1 I've re-requested a review from you because I've added my latest attempt at the mmap bug workaround to this PR |
christiaanb
approved these changes
Sep 14, 2023
|
@leonschoorl |
leonschoorl
force-pushed
the
bump-tasty
branch
from
28d1aad to
9835708
Compare
https://gitlab.com/clash-lang/clash-compiler/-/jobs/5098978057 |
DigitalBrains1
requested changes
Sep 15, 2023
…nfig This avoids the issue having to selectively pass around GHCRTS, because it broke the building of certain packages. But a downside is this doesn't work for binaries that have -with-rtsopts set locally, because that option isn't cumulative.
The GHC 8.6.5 job was doing the error while loading shared libraries: libHS...so: cannot open shared object file: No such file or directory
leonschoorl
force-pushed
the
bump-tasty
branch
from
9835708 to
edf3f1b
Compare
DigitalBrains1
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still TODO:
Write a changelog entry (see changelog/README.md)Check copyright notices are up to date in edited files